merge proposal diffs have undifferentiated 'preview.diff' filename

Bug #335205 reported by Eleanor Berger
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

The fix for bug #327135 is awesome - I can now download a diff from the merge proposal page. It gets downloaded as 'preview.diff' regardless of the branch / revno etc. Some sort of generated name would make it easier to figure out which diff is which in ones downloaded files directory.

Tags: easy lp-code ui
Revision history for this message
Tim Penhey (thumper) wrote : Re: [Bug 335205] [NEW] Downloadable diffs should come with a nice filename

On Fri, 27 Feb 2009 12:11:21 Tom Berger wrote:
> Public bug reported:
>
> The fix for bug #327135 is awesome - I can now download a diff from the
> merge proposal page. It is being served without a filename, using
> whatever random name it got from the librarian. It would be much better
> if it came with a useful filename in the header.
>
> ** Affects: launchpad-bazaar
> Importance: Undecided
> Status: New

Yeah, I intended to have it use branch name and rev-no, but I hadn't exposed a
filename option on diff upload.

Will fix.

Paul Hummer (rockstar)
Changed in launchpad-bazaar:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Robert Collins (lifeless) wrote : Re: Downloadable diffs should come with a nice filename

Now consistently shows as preview.diff. Redescribing to match the new behaviour.

Changed in launchpad:
importance: Medium → Low
summary: - Downloadable diffs should come with a nice filename
+ merge proposal diffs have undifferentiated 'preview.diff' filename
description: updated
tags: added: easy ui
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.