+newaccount causes OOPS

[Brad Crittenden]

An OOPS was generated when a user tried to claim a token to create a new account.

OOPS-1153E919

An email address exists for the user but person.account is None which causes an error. The code as written is not defensive at all.

This is a race condition, and very unlikely to happen. To reproduce you have to start the registration process in LP using a given (not taken) email address, then before completing that registration you add that same email address to a team. Then when you follow the link to finish the registration process you'll get that failure.

[Curtis Hovey (sinzui)]

I think Salgado is working in related and may have some insight into this issue. We certainly want to fix this, and I hope the Account/Person separation work will do it.

[Guilherme Salgado (salgado)]

Given how unlikely this is to happen, I'm not sure its priority should be high.

[Guilherme Salgado (salgado)]

Also not fixed by the work I finished last week.

[Curtis Hovey (sinzui)]

I'm lowering the priority given the new assessment of the issue. I want to keep it assigned for a short while longer in case a cluster of more oopses happens.

[Guilherme Salgado (salgado)]

This actually is a dupe of bug 185083. If you reproduce the steps described on that bug on staging you'll see a nearly identical traceback -- it's not really identical because the code on staging is different than what we had when the OOPSes listed here happened.