"Please try again" page is crooked
Bug #330035 reported by
Matthew Paul Thomas
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Chris Johnston |
Bug Description
In Launchpad's "Please try again" page <https:/
This is because all paragraphs in Launchpad have a max-width of 60em for readability, but on the offline page only the text alignment is centered, not the paragraphs as a whole.
The fix is to change
.offline {text-align: center;}
to
.offline {text-align: center;}
.offline>* {margin-left: auto; margin-right: auto;}
Related branches
lp:~sinzui/launchpad/css-ui-0
- Edwin Grubbs (community): Approve (code)
-
Diff: 560 lines (+149/-117)16 files modifiedlib/canonical/launchpad/icing/style-3-0.css.in (+2/-2)
lib/canonical/launchpad/icing/style.css (+0/-1)
lib/canonical/launchpad/offline-maintenance-haproxy.html (+42/-32)
lib/canonical/launchpad/offline-maintenance.html (+11/-1)
lib/canonical/launchpad/offline-staging-code-update.html (+11/-1)
lib/canonical/launchpad/offline-staging-db-update.html (+11/-1)
lib/canonical/launchpad/offline-unplanned-haproxy.html (+42/-32)
lib/canonical/launchpad/offline-unplanned.html (+11/-1)
lib/canonical/launchpad/webapp/interfaces.py (+5/-13)
lib/canonical/launchpad/webapp/login.py (+2/-2)
lib/canonical/launchpad/webapp/notifications.py (+3/-12)
lib/lp/app/browser/tests/test_launchpad.py (+1/-1)
lib/lp/app/stories/basics/xx-notifications.txt (+2/-8)
lib/lp/app/templates/base-layout-macros.pt (+0/-4)
lib/lp/blueprints/browser/tests/test_specification.py (+3/-3)
lib/lp/registry/browser/person.py (+3/-3)
lp:~cjohnston/launchpad/330035
- William Grant: Approve (code)
-
Diff: 95 lines (+6/-18)6 files modifiedlib/canonical/launchpad/offline-maintenance-haproxy.html (+1/-3)
lib/canonical/launchpad/offline-maintenance.html (+1/-3)
lib/canonical/launchpad/offline-staging-code-update.html (+1/-3)
lib/canonical/launchpad/offline-staging-db-update.html (+1/-3)
lib/canonical/launchpad/offline-unplanned-haproxy.html (+1/-3)
lib/canonical/launchpad/offline-unplanned.html (+1/-3)
description: | updated |
Changed in launchpad-foundations: | |
assignee: | nobody → Martin Albisetti (beuno) |
importance: | Undecided → Medium |
Changed in launchpad-foundations: | |
assignee: | Martin Albisetti (beuno) → nobody |
tags: | added: css |
affects: | launchpad-foundations → launchpad-web |
Changed in launchpad: | |
assignee: | nobody → Curtis Hovey (sinzui) |
status: | Triaged → In Progress |
tags: | added: bugjam2010 |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Changed in launchpad: | |
milestone: | none → 11.01 |
Changed in launchpad: | |
importance: | Medium → Low |
status: | Confirmed → Triaged |
Changed in launchpad: | |
assignee: | Curtis Hovey (sinzui) → nobody |
milestone: | 11.01 → none |
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Chris Johnston (cjohnston) |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I thought this was a dupe of bug 182296 but it is not.