"Please try again" page is crooked

Bug #330035 reported by Matthew Paul Thomas
20
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Chris Johnston

Bug Description

In Launchpad's "Please try again" page <https://launchpad.net/offline.html>, the heading is correctly horizontally centered with respect to the whole viewport; but when the browser window is wider than 60em, the body text is way off to the left.

This is because all paragraphs in Launchpad have a max-width of 60em for readability, but on the offline page only the text alignment is centered, not the paragraphs as a whole.

The fix is to change
    .offline {text-align: center;}
to
    .offline {text-align: center;}
    .offline>* {margin-left: auto; margin-right: auto;}

Related branches

Revision history for this message
Matthew Paul Thomas (mpt) wrote :
Revision history for this message
Diogo Matsubara (matsubara) wrote :

I thought this was a dupe of bug 182296 but it is not.

Changed in launchpad:
status: New → Triaged
description: updated
Martin Albisetti (beuno)
Changed in launchpad-foundations:
assignee: nobody → Martin Albisetti (beuno)
importance: Undecided → Medium
Martin Albisetti (beuno)
Changed in launchpad-foundations:
assignee: Martin Albisetti (beuno) → nobody
Curtis Hovey (sinzui)
tags: added: css
affects: launchpad-foundations → launchpad-web
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: nobody → Curtis Hovey (sinzui)
status: Triaged → In Progress
tags: added: bugjam2010
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
milestone: none → 11.01
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Edwin's branch did make the change I suggested, but it didn't fix this bug. What was I thinking?

To fix the bug, change

    .offline {text-align: center; max-width: 60em;}
    .offline > * {margin-left: auto; margin-right: auto;}

to

    .offline {max-width: 60em; text-align: center; margin-left: auto; margin-right: auto;}

This time I've tested it in Firefox's element inspector, so I'm sure it works. :-) And it will shorten the code, too.

Changed in launchpad:
status: Fix Released → Confirmed
tags: added: trivial
Curtis Hovey (sinzui)
Changed in launchpad:
importance: Medium → Low
status: Confirmed → Triaged
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Curtis Hovey (sinzui) → nobody
milestone: 11.01 → none
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Chris Johnston (cjohnston)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.