Get rid of the no-trailing-slash restriction on branch URIs

[Leonard Richardson]

There seems to be no current reason why a branch URI should not be able to end in a slash (http://foo.com/bar/), especially if the slash is the entire path (http://foo.com/). I've written code that normalizes the handling of slashes in URI fields, but it uses our URI class, which treats "http://foo.com/" as a URL that doesn't need to have its trailing slash removed. I think that's the correct behavior, but setting a branch URI to "http://foo.com/" violates a database constraint.

This bug is to get rid of that database constraint, and to get rid of the special behavior I've put in BranchURIField to chop off the slash at the end of "http://foo.com/".

The branch that introduces the URIField slash normalization is
https://code.edge.launchpad.net/~leonardr/launchpad/representation-on-patch. I'll land it with XXX directives that reference this bug.

[Celso Providelo (cprov)]

The DB constraint in question is: "branch_url_no_trailing_slash" CHECK (url !~~ '%/'::text)

What's the rationale behind it ?

[Jonathan Lange (jml)]

None of us have a clue what the rationale is / was.