No way to differentiate between reviews as yourself, and reviews on behalf of a team

Bug #315123 reported by Māris Fogels on 2009-01-08
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Low
Unassigned

Bug Description

In the code review page there is no way to tell that one of the [Review] links performs the review on behalf of a team, and that the other [Review] link performs the review as yourself, without an associations.

I would expect a clearly labelled link or button indicating that I am performing a review on behalf of a team.

Diogo Matsubara (matsubara) wrote :

Are reviews on behalf of a team really needed? If yes, can you elaborate further on the use case?

Changed in launchpad-bazaar:
status: New → Incomplete

On 09/01/09 11:47 AM, Diogo Matsubara wrote:
> Are reviews on behalf of a team really needed? If yes, can you elaborate
> further on the use case?
>
>
> ** Changed in: launchpad-bazaar
> Product: Launchpad itself => Launchpad Bazaar Integration
>
> ** Changed in: launchpad-bazaar
> Status: New => Incomplete
>
> ** Tags added: code-review confusing-ui
>

I'm not sure what the use case is for reviews on behalf of teams, but my guess
is that they indicate that you asked a specific group of people for a review,
and that a member of the group looked at your code. If this is the case, then I
don't feel that the UI clearly shows this intent.

Lets assume that a person has requested a review from "Canonical Launchpad
Developers", the ~launchpad team. The "Launchpad Developers" review request
line will have a status of "Pending".

In the current UI, if I click the [Review] link beside *my* name, then my review
will end up with a status like "Approved", but the "Launchpad Developers" review
status will still be "Pending", even though I'm a member of the ~launchpad team.
  It looks really weird.

Worse still, I can't go back and edit the ~launchpad team's review request
status - it's stuck as "Pending".

Jonathan Lange (jml) wrote :

Hmm. This *is* a problem. Clicking the [Review] link beside your name should result in a team review, IMO.

Changed in launchpad-bazaar:
importance: Undecided → Low
status: Incomplete → Triaged
Tim Penhey (thumper) wrote :

I recently landed a fix that changed the way team reviews were claimed.

They were mapped by looking for a team that you were a member of that had the same review_type

Now if it can't fine a review with the specified review type, it checks to see if there is one with a review type of "None" :)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers