Launchpad itself

send-bug-notifications.py will explode if the SMTP server refuses to send to a recipient

Bug #314420 reported by Graham Binns
12
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Colin Watson

Bug Description

If the SMTP server refuses to send to a recipient (see https://pastebin.canonical.com/12356/ for an example), send-bug-notifications.py will die without committing to the database any sent notifications. This causes the notifications to be resent ad infinitum and stops send-bug-notifications from running properly.

send-bug-notifications should be updated to handle exceptions from smtplib.sendmail (which is where refusals from the server get turned into exceptions) gracefully and still commit those notifications that have been sent successfully.

Related branches

lp:~cjwatson/launchpad/send-bug-notifications-oops
William Grant (community): Approve (code)
Diff: 290 lines (+143/-47)
3 files modified
cronscripts/send-bug-notifications.py (+1/-44)
lib/lp/bugs/scripts/bugnotification.py (+68/-2)
lib/lp/bugs/scripts/tests/test_bugnotification.py (+74/-1)
Revision history for this message
Graham Binns (gmb) wrote :

Marking this Low since it doesn't occur often.

Changed in malone:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Graham Binns (gmb) wrote :

Marking this high and targeting it to 2.2.1 since elmo reports this has caused problems more than once.

Changed in malone:
importance: Low → High
milestone: none → 2.2.1
Eleanor Berger (intellectronica)
Changed in malone:
assignee: nobody → intellectronica
status: Triaged → In Progress
Eleanor Berger (intellectronica)
Changed in malone:
milestone: 2.2.1 → 2.2.2
Revision history for this message
Björn Tillenius (bjornt) wrote :

This has been marked in progress for over a month. Let's mark it Triaged until work on it begins again.

Changed in malone:
importance: High → Medium
milestone: 2.2.2 → none
status: In Progress → Triaged
Curtis Hovey (sinzui)
Changed in malone:
assignee: Tom Berger (intellectronica) → nobody
Graham Binns (gmb)
tags: added: story-better-bug-notification
Graham Binns (gmb)
tags: added: story-better-notification-sending
Gary Poster (gary)
tags: removed: story-better-bug-notification
Curtis Hovey (sinzui)
Changed in launchpad:
importance: Medium → Low
tags: added: email
removed: story-better-notification-sending
Colin Watson (cjwatson)
Changed in launchpad:
assignee: nobody → Colin Watson (cjwatson)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r17682 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17682>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Colin Watson (cjwatson)
tags: added: qa-untestable
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.