Confirmation of subscribing to a branch is ungrammatical

Bug #314402 reported by Matthew Paul Thomas
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

1. Subscribe to a branch.

What happens: A notification appears of the form
    You have subscribed to this branch with:
    * Send notifications for both branch attribute updates and new revisions added to the branch.
    * Don't send generated diffs with the revision notifications.
    * Do not send any email about code review for this branch.

"With send" does not make sense. Neither does "with don't" or "with do not".

This could be fixed by improving the text of the notification. For example:
* "You have subscribed to code reviews for this branch."
* "You have subscribed to status changes and new revisions for this branch."
* "You have subscribed to status changes, new revisions with diffs, and code reviews for this branch."

Related branches

Revision history for this message
Jonathan Lange (jml) wrote :

Thanks for spotting this Matthew. Feel free to recommend a better way of phrasing the notification.

Changed in launchpad-bazaar:
importance: Undecided → Low
status: New → Triaged
description: updated
Revision history for this message
Aaron Bentley (abentley) wrote : Re: [Bug 314402] Re: Confirmation of subscribing to a branch is ungrammatical

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthew Paul Thomas wrote:
> ** Description changed:
>
> 1. Subscribe to a branch.
>
> What happens: A notification appears of the form
> You have subscribed to this branch with:
> * Send notifications for both branch attribute updates and new revisions added to the branch.
> * Don't send generated diffs with the revision notifications.
> * Do not send any email about code review for this branch.
>
> "With send" does not make sense. Neither does "with don't" or "with do
> not".
>
> - This could be fixed by improving the text of the notification.
> + This could be fixed by improving the text of the notification. For example:
> + * "You have subscribed to code reviews for this branch."
> + * "You have subscribed to status changes and new revisions for this branch."
> + * "You have subscribed to status changes, new revisions with diffs, and code reviews for this branch."

It would be nice not to have a second set of text describing these
choices. Instead, we could say:

       You have subscribed to this branch with the following settings:
       * Send notifications for both branch attribute updates and new
revisions added to the branch.
       * Don't send generated diffs with the revision notifications.
       * Do not send any email about code review for this branch.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAklsny8ACgkQ0F+nu1YWqI20GQCfVU7oiUEu63ylVnMc7wVKypbs
wzIAn2S0parlRG0GKScHNLf2+GcB42Fa
=7iiq
-----END PGP SIGNATURE-----

Revision history for this message
Tim Penhey (thumper) wrote :

I'm happy to go with either way. Matt, do you have a clear preference?

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

I prefer my suggestion because it involves less reading. (The phrase "the following" is in UserInterfaceChecklist as something to avoid largely because it's a telltale sign of shortenable text.) I understand Aaron's desire to share phrasing between the form itself and the notification, but I don't see how to do that understandably, short of embedding a table into the notification using the same layout as the form.

Maybe we're overthinking this, and the notification should say simply "You have subscribed to this branch." or "You have changed your subscription settings for this branch.".

Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Chris Johnston (chrisjohnston)
Changed in launchpad:
assignee: Chris Johnston (chrisjohnston) → nobody
William Grant (wgrant)
Changed in launchpad:
status: In Progress → Triaged
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.