Confirmation of subscribing to a branch is ungrammatical
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Triaged
|
Low
|
Unassigned |
Bug Description
1. Subscribe to a branch.
What happens: A notification appears of the form
You have subscribed to this branch with:
* Send notifications for both branch attribute updates and new revisions added to the branch.
* Don't send generated diffs with the revision notifications.
* Do not send any email about code review for this branch.
"With send" does not make sense. Neither does "with don't" or "with do not".
This could be fixed by improving the text of the notification. For example:
* "You have subscribed to code reviews for this branch."
* "You have subscribed to status changes and new revisions for this branch."
* "You have subscribed to status changes, new revisions with diffs, and code reviews for this branch."
Related branches
- William Grant (community): Needs Fixing
- Curtis Hovey (community): Approve (code)
- Chris Johnston (community): Needs Resubmitting
-
Diff: 45 lines (+5/-5)2 files modifiedlib/lp/code/browser/branchsubscription.py (+0/-1)
lib/lp/code/enums.py (+5/-4)
description: | updated |
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Chris Johnston (chrisjohnston) |
Changed in launchpad: | |
assignee: | Chris Johnston (chrisjohnston) → nobody |
Changed in launchpad: | |
status: | In Progress → Triaged |
Thanks for spotting this Matthew. Feel free to recommend a better way of phrasing the notification.