Drop the confirmation dialog when subscribing myself

[Matthias Urlichs]

Given that "subscribe" has no side effect that an immediate click to "unsubscribe" doesn't revert, please consider dropping the "are you sure" dialog. It's superfluous.

[Christian Reis (kiko)]

Given the fact that unsubscribing is also trivial, I agree here.

[Matthew Paul Thomas (mpt)]

Making something that looks like a link perform a command might be harmless in this case, but it would lessen people's trust in the safety of every other link in Launchpad. The right way to fix this bug is to implement the MaloneBugSubscriptions spec.

[Björn Tillenius (bjornt)]

On Fri, Oct 14, 2005 at 01:42:53AM -0000, Matthew Paul Thomas wrote:
> Making something that looks like a link perform a command might be
> harmless in this case, but it would lessen people's trust in the safety
> of every other link in Launchpad. The right way to fix this bug is to
> implement the MaloneBugSubscriptions spec.

AFAIK, we also currently have a policy that only POST requests may
change the database. BTW, how does MaloneBugSubscriptions handle this?
In the spec I can only see a checkbox, but I can't find how to actually
subscribe to the bug. This should probably be added to the spec.

[Trent Lloyd (lathiat)]

I feel that any changes should be behind a POST, it's a good practice that I have picked up in personal web development and I think that should be carried on in launchpad.

Perhaps it could be an option or something, as I admit as someone that works with malone a lot it can get slightly tedious, but it doesn't annoy me that much.

[Jorge Bernal (koke)]

I agree to the post thing, but two page loads to subscribe to a bug or a spec can slow down developers work a lot. Maybe you can show a confirmation dialog with JS, and do the POST with JS too. I don't know how at this moment, but rubyonrails can do it, so it's possible