Librarian should confirm it is being used from the correct database

[Stuart Bishop]

Librarian clients need to inform the Librarian server of the database name they are connected too.

The Librarian Server needs to assert that this matches the database that it is connected to.

This will help us diagnose the rather worrying duplicate file issues that we are seeing on staging.

The database name can be determined by issuing the SQL:

    SELECT current_database()

[Stuart Bishop (stub)]

Kiko has requested that this land.

spiv - ping me if you can't look at this on Thursday

[Stuart Bishop (stub)]

We might also want to change the error when a file is found to already on disk into a warning (although that is just relieving the symptoms rather than the cause)

[Andrew Bennetts (spiv)]

I have a branch that implements this at: sftp://chinstrap/home/warthogs/archives/spiv/launchpad/librarian-database-agreement

It's in the review queue.

[Andrew Bennetts (spiv)]

Code written; waiting for code review.

[Andrew Bennetts (spiv)]

Regarding the duplicate ID error into a warning, it makes me nervous. In the current situation it appears to be victimising the wrong client, but could just as easily be the other way around.

Perhaps if the client provides the new Database-Name header that explicitly shows that the client and server are using the same DB, then it could downgrade to a warning, but that's a fair bit of complexity for probably not much gain -- and still leaves me nervous :)

[Christian Reis (kiko)]

Is this not fix-released?