Requesting a review doesn't talk much about reviewing

[Björn Tillenius]

When you finish a branch, you want to want to request a review for it. Now, how do you do that? Well, you... propose the branch for merging into another branch? That's not very intuitive, and I doubt people will find it.

Having the UI talk about requesting a review for the branch would be better, since that's what you usually do.

Further more, the mail notifications that get sent should also talk about reviews. If you get an e-mail saying that someone proposed to merge a branch into another one, it doesn't tell you that it needs to be reviewed.

[Tim Penhey (thumper)]

Hi Martin,

Can you suggest some of that UI goodness to smooth the process?

[Martin Albisetti (beuno)]

So, this is interesting.
We have 2 separate actions, which are complementary: a merge request, and a review request.

The first question, for me is, does it make sense to want to request a review without the intention of merging it?

[Aaron Bentley (abentley)]

I think it does make sense to request a review without intending to merge. For example, I just asked you to perform a UI review before I had gotten the code ready for merging. I think the case where the code is *never* intended to merge is very rare.

[Aaron Bentley (abentley)]

If this was really high-priority, it would be fixed by now.