notify package uploader of import failures

Bug #286359 reported by Colin Watson on 2008-10-20
6
Affects Status Importance Assigned to Milestone
Launchpad itself
High
Данило Шеган

Bug Description

<Riddell> I don't understand why launchpad doesn't e-mail you if there are import failures
<Riddell> it seems like the sort of issue that packagers would want to know about

This is similar to bug 148425, but not quite the same thing. I believe that bug is referring to the person who uploaded the translations to Launchpad, which in the case of automatic imports due to package uploads to Ubuntu is rosetta-admins. In this case, we would also like the person who uploaded the package to Soyuz to be notified.

Jeroen T. Vermeulen (jtv) wrote :

This is not related to bug 148425. The import queue already notifies the uploader of a translation file of failures by email. (And while we're at it, of successes and partial failures as well). Bug 148425 is only about adding a certain class of warning output to those emails.

The problem *here* is what to do with notification about uploads produced by Soyuz. Rosetta is unaware of the person behind the Soyuz package upload, and so reports to the Launchpad Translations development team instead. If Soyuz can provide us with the right person to contact, we could change that. Given the number of emails this can generate, however, it will be important to talk to everyone involved and prevent surprises!

The import-queue-failed-error-display blueprint can also help alleviate this problem by making users less reliant on the emails: https://blueprints.launchpad.net/rosetta/+spec/import-queue-failed-error-display

Jeroen T. Vermeulen (jtv) wrote :

Interestingly, all of this is already provided for as far as I can see. SourcePackageRelease.attachTranslationFiles takes an "importer" argument, which it passes on to Rosetta. Except that argument is always left blank when attachTranslationFiles is called!

Julian Edwards (julian-edwards) wrote :

Soyuz knows about the upload sponsor and the packager (i.e. who signed what files).

Which of these should be emailed? I can then talk to JTV can tell him where to get that info from the Soyuz bits.

Colin Watson (cjwatson) wrote :

I would say that translation import errors should be sent to the same people who would receive notifications if the upload had been rejected, which IIRC is the person who changed the package and the person who signed it, except probably with some quirks to avoid spamming Debian developers when we sync their packages into Ubuntu. Ideally, Rosetta would borrow a Soyuz method for this.

Jeroen T. Vermeulen (jtv) wrote :

No need to borrow anything: in terms of code, this issue is entirely internal to Soyuz. The Soyuz method SourcePackageRelease.attachTranslationFiles already passes the identity of the responsible user to Rosetta; it's just that PackageUploadCustom.publish_ROSETTA_TRANSLATIONS (also in Soyuz) does not give it one, and so None gets passed down the line.

Actually I'm inclined to call this a Soyuz request!

Celso Providelo (cprov) wrote :

We can pass 'importer' to `attachTranslationFiles`, that would help. But be aware that SourcePackageRelease records have 3 classes of contact -points:

 * SPR.creator -> person or team (Changed-By:)
 * SPR.maintainer -> person or team (Maintainer:)
 * SPR.signing_key.owner -> person (usually the 'creator', but might vary)

Note that they are all available at the SPR level, so the 'import' argument doesn't make much sense if we will be always taking about of one (or all) of those categories.

I'm more than happy to help you with anything you need from Soyuz to get it fixed for 2.2.1.

Changed in rosetta:
assignee: nobody → danilo
importance: Undecided → High
milestone: none → 2.2.2
status: New → Triaged

Fixed in 7746. Still to work out where to send debian auto-sync emails to (I am thinking of a mailing list on lists.ubuntu.com, but that might not work too well). We'll need to start announcing this soon: it's going to affect all Ubuntu packagers.

Changed in rosetta:
status: Triaged → Fix Committed
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers