requesting review by a team should send mail to that team
Bug #281056 reported by
Paul Hummer
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Medium
|
Tim Penhey |
Bug Description
In merge proposal code, this XXX comment is found:
"If the reviewer is a team, don't send email. This is to stop the abuse of a user spamming all members of a team by requesting them to review a (possibly unrelated) branch. Ideally we'd come up with a better solution, but I can't think of one yet. In all other places we are emailing subscribers directly rather than people that haven't subscribed."
A new solution is needed.
Related branches
lp:~thumper/launchpad/new-reviewer-email-job
Merged
into
lp:launchpad
- Brad Crittenden (community): Approve (code)
-
Diff: 415 lines (+201/-34)8 files modifiedlib/lp/code/configure.zcml (+10/-0)
lib/lp/code/interfaces/branchmergeproposal.py (+19/-0)
lib/lp/code/mail/branch.py (+6/-7)
lib/lp/code/mail/branchmergeproposal.py (+3/-16)
lib/lp/code/mail/tests/test_branch.py (+7/-3)
lib/lp/code/mail/tests/test_branchmergeproposal.py (+79/-5)
lib/lp/code/model/branchmergeproposal.py (+2/-1)
lib/lp/code/model/branchmergeproposaljob.py (+75/-2)
Changed in launchpad-bazaar: | |
assignee: | nobody → thumper |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in launchpad-bazaar: | |
assignee: | thumper → nobody |
tags: | added: code-review |
summary: |
- Better solution needed for reviews to team subscribed branches + requesting review by a team should send mail to that team |
tags: | added: email |
Changed in launchpad-code: | |
status: | Triaged → In Progress |
assignee: | nobody → Tim Penhey (thumper) |
Changed in launchpad-code: | |
status: | In Progress → Fix Committed |
milestone: | none → 10.04 |
tags: |
added: qa-needstesting removed: qa-bad |
Changed in launchpad-code: | |
status: | In Progress → Fix Committed |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
On Fri, Oct 10, 2008 at 1:03 PM, Paul Hummer <email address hidden> wrote:
> Public bug reported:
>
> In merge proposal code, this XXX comment is found:
>
> "If the reviewer is a team, don't send email. This is to stop the abuse
> of a user spamming all members of a team by requesting them to review a
> (possibly unrelated) branch. Ideally we'd come up with a better
> solution, but I can't think of one yet. In all other places we are
> emailing subscribers directly rather than people that haven't
> subscribed."
I don't see why this is any worse than a team being subscribed to get
all bug mail for a product?
-- launchpad. net/~mbp/>
Martin <http://