Hookable error logging for smart servers

Bug #274578 reported by Michael Hudson-Doyle
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
High
Jonathan Riddell
Launchpad itself
Triaged
High
Unassigned

Bug Description

If something unexpected happens in the 'bzr lp-serve' process we spawn on a bzr+ssh connection, we don't find out about it (well, we probably get a report that a subprocess exited with code 1 in our logs). The unlucky user probably gets a traceback in their terminal.

We should log an oops.

I think we can probably do this in sys.excepthook.

Related branches

Revision history for this message
Jonathan Lange (jml) wrote :

This is really important to fix. We need error reporting.

Changed in launchpad-bazaar:
importance: Undecided → High
status: New → Triaged
Jonathan Lange (jml)
tags: added: codehosting-ssh
Jonathan Lange (jml)
Changed in launchpad-code:
assignee: nobody → Jonathan Lange (jml)
status: Triaged → In Progress
Jonathan Lange (jml)
Changed in launchpad-code:
status: In Progress → Fix Committed
Revision history for this message
Jonathan Lange (jml) wrote :

I ended up doing this by monkeypatching bzrlib.trace.log_exception_quietly. That doesn't work, however, since modules import log_exception_quietly before the monkeypatcher runs. Suck.

I'm going to do this right by adding a hook to bzr itself.

Changed in launchpad-code:
status: Fix Committed → In Progress
milestone: none → 2.2.9
Revision history for this message
Jonathan Lange (jml) wrote :

I'll add the hook to bzr.

Changed in bzr:
assignee: nobody → Jonathan Lange (jml)
importance: Undecided → Medium
status: New → In Progress
summary: - tracebacks in lp-serve are not logged anywhere
+ Hookable error logging for smart servers
Revision history for this message
Matthew Revell (matthew.revell) wrote :

Retargeting to 3.0, which is the new name for 2.2.9. Haven't renamed the milestone as the 3.0 milestone is in a different series.

Changed in launchpad-code:
milestone: 2.2.9 → 3.0
Jonathan Lange (jml)
Changed in bzr:
status: In Progress → Triaged
Changed in launchpad-code:
status: In Progress → Triaged
Revision history for this message
Jonathan Lange (jml) wrote :

As mentioned in my earlier comment, this requires a change to Bazaar. However, I'm not going to be able to do it.

Changed in bzr:
assignee: Jonathan Lange (jml) → nobody
Changed in launchpad-code:
assignee: Jonathan Lange (jml) → nobody
Tim Penhey (thumper)
Changed in launchpad-code:
milestone: 3.0 → 3.1.10
Tim Penhey (thumper)
Changed in launchpad-code:
milestone: 3.1.10 → none
Martin Pool (mbp)
Changed in bzr:
status: Triaged → Confirmed
Martin Pool (mbp)
Changed in bzr:
importance: Medium → High
Martin Pool (mbp)
Changed in bzr:
assignee: nobody → canonical-bazaar (canonical-bazaar)
Jonathan Riddell (jr)
Changed in bzr:
assignee: canonical-bazaar (canonical-bazaar) → Jonathan Riddell (jr)
Jonathan Riddell (jr)
Changed in bzr:
status: Confirmed → In Progress
Vincent Ladeuil (vila)
Changed in bzr:
milestone: none → 2.4b4
status: In Progress → Fix Released
tags: added: oops-infrastructure
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.