No way to see merged/inactive code reviews for a project
Bug #263920 reported by
James Henstridge
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Medium
|
Tim Penhey |
Bug Description
While showing a new developer the ropes of our code review process, I wanted to show a few completed code reviews as examples.
I couldn't see an obvious way display this from either the project code page or the development focus branch page. A quick browse of the source code didn't show anything either.
It'd be nice to have a view like $project/
Related branches
lp:~thumper/launchpad/branch-active-reviews
- Michael Nelson (community): Approve (ui)
- Paul Hummer (community): Approve (code ui*)
-
Diff: 159 lines (+42/-21)6 files modifiedlib/lp/code/browser/branchmergeproposallisting.py (+12/-6)
lib/lp/code/browser/configure.zcml (+7/-0)
lib/lp/code/browser/tests/test_branchmergeproposallisting.py (+0/-14)
lib/lp/code/stories/branches/xx-branchmergeproposal-listings.txt (+16/-0)
lib/lp/code/templates/active-reviews.pt (+6/-0)
lib/lp/code/templates/branch-pending-merges.pt (+1/-1)
Changed in launchpad-code: | |
status: | Triaged → In Progress |
assignee: | nobody → Tim Penhey (thumper) |
milestone: | none → 10.01 |
Changed in launchpad-code: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
Good point.