Inconsistent CSS for bug comments vs. merge proposal comments

Bug #262718 reported by Matthew Paul Thomas on 2008-08-29
Affects Status Importance Assigned to Milestone
Launchpad itself

Bug Description

Bug descriptions and comments use the fmt:text-to-html formatter to convert them into <p> and <div> elements, and (via id="bug-description" and class="bug-comment") special CSS to convert them to monospace.

Meanwhile merge proposal comments use <pre style="white-space: pre-wrap;">, which produces a single line of text per paragraph -- regardless of the length of the paragraph -- in browsers like Firefox 2, Internet Explorer 7 and Safari 2.0.

These should be made more consistent and cross-browser. Either:
* merge proposal comments should use fmt:text-to-html like bug descriptions and comments do, and all three should use a class= to achieve a monospace font; or
* bug descriptions, bug comments, and merge proposal comments should all use <pre>, and <pre> should be styled using {white-space: pre-wrap} as well as browser-specific properties like word-break so that it wraps in as many browsers as possible.

description: updated
Curtis Hovey (sinzui) on 2009-11-06
affects: launchpad-foundations → launchpad-code
Deryck Hodge (deryck) wrote :

Tim and I had a conversation at the last Launchpad team leads sprint about getting our teams' handling of comments in sync. Some of the specifics of this bug are out of date, but the basic point of <pre> vs. class and inconsistencies between bugs and merge proposals is still relevant.

Changed in malone:
status: New → Triaged
importance: Undecided → Low
Tim Penhey (thumper) wrote :

There are fundamental differences though.

Bug comments are normally prose, whereas many code review comments have code samples, and as such are much better with monospace. There are other differences too. Perhaps we should get together and normalise through.

Changed in launchpad-code:
importance: Undecided → Low
status: New → Triaged
Curtis Hovey (sinzui) on 2009-12-21
tags: added: css

2010/1/19 Martin Albisetti <email address hidden>:
> *** This bug is a duplicate of bug 405476 ***
> ** This bug has been marked a duplicate of bug 405476
>   sprite class bleeds extra images in tall elements

@beuno is that really true? They don't seem similar to me.

Martin <>

Martin Albisetti (beuno) wrote :

It isn't, I'm on crack. Thanks for pointing it out Martin.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers