Normal comments duplicated if they are in the .pot file

Bug #26 reported by Carlos Perelló Marín
6
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Данило Шеган

Bug Description

If the .pot file has normal comments (the ones marked as '# '), the .po file inherit it and when Rosetta exports the .po file again, the comment is there twice.

After playing with msgmerge, seems like they ignore that kind of comments from the .pot file as soon as the msgset exists in the .po file.

We should fix our code to do something like that.

Changed in rosetta:
assignee: None → carlos
status: New → Accepted
Revision history for this message
Dafydd Harries (daf) wrote :

Does this affect the web UI, or just the exported files?
For exports, is it just a matter of not using the "normal" comment from the template if one exists in the PO file?

Revision history for this message
Carlos Perelló Marín (carlos) wrote :

After some code checks I think it's an issue with the exported files.

Revision history for this message
Carlos Perelló Marín (carlos) wrote :

Yes, the solution is just export the comment from the template if there is no comments from the PO file. So the PO file should override the ones from the template.

Revision history for this message
Данило Шеган (danilo) wrote :

This seems to have been fixed (I tested locally with the refactoring branch), in at least RF 5199, but probably even earlier.

Changed in rosetta:
assignee: carlos → danilo
milestone: none → 1.1.11
status: Confirmed → Fix Released
status: Fix Released → Fix Committed
Revision history for this message
Carlos Perelló Marín (carlos) wrote :

It was fixed in RF 5199, I fixed that or at least I remember changing some code related with that

Changed in rosetta:
status: Fix Committed → Fix Released
tags: added: iso-testing
tags: removed: iso-testing
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers