Remove XML-RPC DateTime marshalling and unmarshalling code when Launchpad is upgraded to run on Python2.5
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Gavin Panella | ||
Bug Description
At the moment there are a couple of places where we marshal datetime.datetime objects manually into xmlrpclib.DateTime objects because, if we don't, xmlrpclib will explode with the error:
TypeError: cannot marshal <type 'datetime.
Furthermore, we currently manually unmarshal xmlrpclib.DateTimes in a couple of places. Python 2.5 allows us to specify use_datetime=True when we create ServerProxies, which will cause it to automatically unmarshal xmlrplib.DateTimes in to datetime.datetimes.
These manual marshallings and unmarshallings occur at:
l/c/l/
l/c/l/
l/c/l/
l/c/l/
l/c/l/
Related branches
- Brad Crittenden (community): Approve (code)
-
Diff: 894 lines (+102/-210)7 files modifiedlib/lp/bugs/doc/externalbugtracker-bugzilla-api.txt (+13/-17)
lib/lp/bugs/doc/externalbugtracker-bugzilla-lp-plugin.txt (+10/-10)
lib/lp/bugs/externalbugtracker/bugzilla.py (+18/-71)
lib/lp/bugs/externalbugtracker/xmlrpc.py (+2/-3)
lib/lp/bugs/tests/bugzilla-api-xmlrpc-transport.txt (+26/-41)
lib/lp/bugs/tests/bugzilla-xmlrpc-transport.txt (+22/-35)
lib/lp/bugs/tests/externalbugtracker.py (+11/-33)
| description: | updated |
| description: | updated |
| Changed in malone: | |
| importance: | Undecided → Low |
| status: | New → Triaged |
| tags: | added: tech-debt |
| Gavin Panella (allenap) wrote | #1 |
| Changed in malone: | |
| assignee: | nobody → Gavin Panella (allenap) |
| status: | Triaged → In Progress |
| Diogo Matsubara (matsubara) wrote Bug fixed by a commit | #2 |
| Changed in malone: | |
| status: | In Progress → Fix Committed |
| Changed in malone: | |
| milestone: | none → 10.01 |
| Changed in malone: | |
| status: | Fix Committed → Fix Released |
| visibility: | private → public |
Doing this as I read through the checkwatches and externalbugtracker code.