bzr pull URL redirects to 'changes'

[Robert Collins]

Bazaar redirects to a 'changes' URL when pulling from a Launchpad http URL. For example,

/tmp$ bzr init branch
/tmp$ cd branch
/tmp/branch$ bzr pull http://bazaar.launchpad.net/~jelmer/bzr-svn/0.4
http://bazaar.launchpad.net/%7Ejelmer/bzr-svn/0.4 is permanently redirected to /~jelmer/bzr-svn/0.4/changes

Bazaar shouldn't redirect here. Instead it should pull the branch at http://bazaar.launchpad.net/~jelmer/bzr-svn.

Note that 'bzr branch http://bazaar.launchpad.net/~jelmer/bzr-svn' works.

[Jonathan Lange (jml)]

Robert,

Can you please explain why you think this is a bug in Launchpad Bazaar rather than a bug in Bazaar?

jml

[Andrew Bennetts (spiv)]

When pulling and merging, the first thing bzr does is try to fetch the URL as a file, in case it is the URL to a merge directive (i.e. bundle). I think our loggerhead/apache configuration issues a redirect for a GET to bazaar.launchpad.net/~USER/PROJECT/BRANCH.

"bzr branch ..." doesn't have this issue because it doesn't do this check.

It's not immediately clear to me if the fault lies with bazaar.launchpad.net, the bzr client, or both.

[Robert Collins (lifeless)]

On Mon, 2008-07-21 at 00:57 +0000, Jonathan Lange wrote:
> Robert,
>
> Can you please explain why you think this is a bug in Launchpad Bazaar
> rather than a bug in Bazaar?

because bzr is perfect and love.

Or more sensibly, because bzr needs to make the request it makes, but
launchpad-bazaar has enough info to decide not to redirect to /changes
which is a purely browser specific resource.

(Also, redirecting to /changes is a bit ugly anyway).

-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.

[Tim Penhey (thumper)]

On Tuesday 22 July 2008 11:05:47 Robert Collins wrote:
> On Mon, 2008-07-21 at 00:57 +0000, Jonathan Lange wrote:
> > Robert,
> >
> > Can you please explain why you think this is a bug in Launchpad Bazaar
> > rather than a bug in Bazaar?
>
> because bzr is perfect and love.
>
> Or more sensibly, because bzr needs to make the request it makes, but
> launchpad-bazaar has enough info to decide not to redirect to /changes
> which is a purely browser specific resource.
>
> (Also, redirecting to /changes is a bit ugly anyway).

Which really makes this a bug in loggerhead, as that is what is causing
the redirect.

Tim

[Jonathan Lange (jml)]

OK, so this *is* a bug in our deployment. I don't know the right way to fix it though.

[Robert Collins (lifeless)]

Taking 'high' off because we generally have folk use lp: urls and we now use bzr+ssh for all logged in users.