Reporting a bug with an attachment produces two info alerts

Bug #249471 reported by Matthew Paul Thomas
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

1. Report a bug with an attachment included.

What happens: The resulting page has two info alerts, "Thank you for your bug report" and "The file 'whatever' was attached to the bug report".

What should happen: The page has only one info alert, "Thank you for your bug report". An alert about an attachment should appear only if you attach a file to an existing bug report, without also adding a comment.

Fixing bug 271615 won't also fix this bug. See also bug 250561.

description: updated
description: updated
description: updated
Changed in malone:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Matthew Paul Thomas (mpt) wrote :
Revision history for this message
Bryce Harrington (bryce) wrote :

Well the extra notice about having an attachment never really bothered me, but I can see how it's a bit cluttery. I definitely agree the apport attachments notices stuff gets out of control.

Anyway, here's a patch that implements what is described in the description.

I didn't test this with apport, but the code tries to detect whether 1 or >1 attachment were provided. In the latter case it'll give the notice that "<N> files were attached to the bug report" which I think is most appropriate.

Revision history for this message
Bryce Harrington (bryce) wrote :
Curtis Hovey (sinzui)
Changed in launchpad:
importance: Medium → Low
Revision history for this message
Robert Collins (lifeless) wrote :

I've unduped this, as this isn't to do with the rendering of said notices, but the number and generation of them.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.