Branch +merges page shows reviews newest-first, should be oldest-first

[Robert Collins]

I think that the list of 'Branches proposed to be merged into this one' on a branch page might be nicer if it was in oldest-first order (because most folk will be wanting to review in oldest-first order)

[Michael Hudson-Doyle (mwhudson)]

This was fixed a good while ago.

[Michael Hudson-Doyle (mwhudson)]

Wrong bug damnit.

[Tim Penhey (thumper)]

The view has changed completely, but the bug is still relevant.

[Jonathan Lange (jml)]

See https://code.edge.launchpad.net/~launchpad-pqm/launchpad/devel/+merges for an example.

[Aaron Bentley (abentley)]

I don't agree. For the +merges page, showing oldest-first means showing ancient merged proposals before showing anything recent active reviews, and that is not useful.

[Robert Collins (lifeless)]

On Fri, 2010-03-05 at 16:53 +0000, Aaron Bentley wrote:
> I don't agree. For the +merges page, showing oldest-first means showing
> ancient merged proposals before showing anything recent active reviews,
> and that is not useful.

That suggests that you want active reviews split out and made visually
distinctive.

Some possibilities:
- sort by status(active, merged, rejected, superseded), age: that should
give the oldest unmerged reviews first on the page.
- have separate regions for each status
- do something else again

-Rob

[Robert Collins (lifeless)]

Note that the sample page now shows a batch of 6000 merge proposals by default, so this bug is arguably more relevant than ever ;)