setPreferredEmail should require activated accounts
Bug #248518 reported by
Curtis Hovey
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Edwin Grubbs |
Bug Description
Person.
Callsites should ensure the person has an active account /before/ calling setPreferredEmail() so that
the method has less responsability..
Related branches
lp:~edwin-grubbs/launchpad/bug-248518-setPreferredEmail
Merged
into
lp:launchpad
- Curtis Hovey (community): Approve (code)
-
Diff: 120 lines (+23/-20)5 files modifiedlib/lp/bugs/browser/bugalsoaffects.py (+1/-1)
lib/lp/bugs/browser/tests/bugtask-adding-views.txt (+0/-1)
lib/lp/registry/doc/person.txt (+13/-5)
lib/lp/registry/model/person.py (+0/-11)
lib/lp/testing/factory.py (+9/-2)
Changed in launchpad: | |
status: | New → Confirmed |
Changed in launchpad-registry: | |
importance: | Undecided → Low |
status: | Confirmed → Triaged |
tags: |
added: tech-debt removed: cleanup |
visibility: | private → public |
Changed in launchpad-registry: | |
assignee: | nobody → Edwin Grubbs (edwin-grubbs) |
status: | Triaged → In Progress |
summary: |
- setPreferredEmail activated accounts + setPreferredEmail should require activated accounts |
Changed in launchpad-registry: | |
status: | In Progress → Fix Committed |
tags: |
added: qa-ok removed: qa-needstesting |
To post a comment you must log in.
Because Launchpad relies on the SSO and it does the password reset, Person. setPreferredEma il() should never be called with a deactivated account. The acount logic can be removed.