Email for a question converted from a bug has the wrong sender
Bug #247685 reported by
Brad Crittenden
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Curtis Hovey | ||
Bug Description
When a bug is converted to a question an email is sent to answer contacts which includes the text of the original bug. Unfortunately the apparent sender of the question email is the person who did the conversion. This is confusing -- the email sender should the the original owner of the bug.
Additional commentary from Bjorn on IRC:
<BjornT> bac: i tested it locally, and i'd say it's indeed a bug. the logged in user is used instead of question.owner
<BjornT> at least using question.owner is the easiest solution. it would probably make sense to send a special kind of notification, so that it's clear that this is a bug that got converted.
Related branches
lp:~sinzui/launchpad/bugtask-create-question-1
- Brad Crittenden (community): Approve (code)
-
Diff: 291 lines (+115/-27)6 files modifiedlib/lp/answers/doc/notifications.txt (+8/-4)
lib/lp/answers/model/question.py (+12/-7)
lib/lp/answers/notification.py (+17/-10)
lib/lp/answers/tests/test_question_notifications.py (+32/-1)
lib/lp/answers/tests/test_questiontarget.py (+42/-1)
lib/lp/bugs/tests/test_bugtarget.py (+4/-4)
| affects: | launchpad-foundations → launchpad-answers |
| Changed in launchpad-answers: | |
| importance: | Undecided → Low |
| status: | New → Triaged |
| tags: | added: bugs questions |
| Changed in launchpad: | |
| assignee: | nobody → Curtis Hovey (sinzui) |
| milestone: | none → 11.05 |
| status: | Triaged → In Progress |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-ok |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
