+activereviews for a project isn't helpful if there are no reviews

Bug #244772 reported by Tim Penhey
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

If there are no proposed merges in needs review state the message

"<project> has no active code reviews."

This isn't overly helpful as it doesn't help the person work out what needs to happen in order to get something appearing there.

Tags: lp-code ui
Revision history for this message
Tim Penhey (thumper) wrote :

This also applies to +approvedmerges.

Changed in launchpad-bazaar:
importance: Undecided → High
status: New → Confirmed
Jonathan Lange (jml)
Changed in launchpad-bazaar:
assignee: nobody → jml
milestone: none → 1.99
status: Confirmed → Triaged
Revision history for this message
Jonathan Lange (jml) wrote :

Maybe. What *would* be helpful though?

Changed in launchpad-bazaar:
assignee: jml → thumper
Revision history for this message
Tim Penhey (thumper) wrote :

I think some help text that explains what an "Active review" is, and why you want to use them.

Tim Penhey (thumper)
Changed in launchpad-bazaar:
milestone: 1.99 → 2.1.8
Tim Penhey (thumper)
Changed in launchpad-bazaar:
milestone: 2.1.8 → 2.1.9
Paul Hummer (rockstar)
Changed in launchpad-bazaar:
assignee: thumper → rockstar
importance: High → Medium
milestone: 2.1.9 → 2.1.10
Paul Hummer (rockstar)
Changed in launchpad-bazaar:
milestone: 2.1.10 → 2.1.11
Paul Hummer (rockstar)
Changed in launchpad-bazaar:
milestone: 2.1.11 → 2.1.12
Paul Hummer (rockstar)
Changed in launchpad-bazaar:
milestone: 2.1.12 → 2.2.1
Paul Hummer (rockstar)
Changed in launchpad-bazaar:
milestone: 2.2.1 → 2.2.2
Paul Hummer (rockstar)
Changed in launchpad-bazaar:
milestone: 2.2.2 → 2.2.3
Tim Penhey (thumper)
Changed in launchpad-bazaar:
milestone: 2.2.3 → 2.2.4
Revision history for this message
Paul Hummer (rockstar) wrote :

I'm doing this along with the second half of 325985

Changed in launchpad-code:
milestone: 2.2.4 → 2.2.5
status: Triaged → In Progress
Paul Hummer (rockstar)
Changed in launchpad-code:
milestone: 2.2.5 → 2.2.6
Paul Hummer (rockstar)
Changed in launchpad-code:
importance: Medium → Low
Paul Hummer (rockstar)
Changed in launchpad-code:
milestone: 2.2.6 → 2.2.7
Revision history for this message
Tim Penhey (thumper) wrote :

This doesn't seem to be happening. Has been deferred over and over again.

We should sit down and organise some ideas around this next week.

Changed in launchpad-code:
milestone: 2.2.7 → 2.2.8
Tim Penhey (thumper)
Changed in launchpad-code:
milestone: 2.2.8 → 3.1.10
Paul Hummer (rockstar)
Changed in launchpad-code:
milestone: 3.1.10 → none
assignee: Paul Hummer (rockstar) → nobody
status: In Progress → Triaged
Colin Watson (cjwatson)
tags: removed: trivial
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.