Participating in code review discussion should subscribe to that discussion

[Aaron Bentley]

When someone participates in code review discussion, they should be apprised of future discussion. Having actual subscriptions would be nice, so that people can control them. Since that's been vetoed, merely having participated should function as a subscription.

[Diogo Matsubara (matsubara)]

How one would unsubscribe?

Why subscriptions were vetoed?

[Tim Penhey (thumper)]

A merge proposal is meant to be short lived. Subscriptions were vetoed due to the short life of the proposals themselves.

People who are subscribed to the source or target branches of a proposal will receive emails. What we are attempting to do here is akin to the sticky threads in mailing lists, in that once you participate in a conversation, you are kept informed about *that* conversation, not all conversations about the source or target.

[Björn Tillenius (bjornt)]

+1 for this bug. I often reply code review comments via e-mail, and without being explicitly subscribed to the discussion, it's very hard for me to participate in the thread, since replies to me don't get my attention (now I have to read through all the comments to all merge proposals for Launchpad to find replies to my comments, and I surely miss some, since there are a lot of comments there).

At the moment I usually CC the ones that will probably reply to me, and hope that they will use reply-to-all, so that they sent a mail directly to me.

BTW, when fixing this bug, it's important to make it possible to see that mail you get from being subscribed to a review thread is different from mail you get by being subscribed to a project's reviews in general. By "see", I mean being able to filter it using an e-mail header (X-Launchpad-Message-Rationale probably would work)