test suite doesn't emit deprecation warnings

[Aaron Bentley]

Two long-deprecated methods were removed in Bazaar 1.5. This broke some of our code. Therefore, it appears that deprecation warnings are not being emitted by the test suite.

[Jonathan Lange (jml)]

I remember adding a patch to make sure that DeprecationWarnings didn't *fail* the test suite (all warnings fail the LP test suite unless explicitly stated otherwise). It's possible that this change entirely suppressed the deprecation warnings from bzrlib.

...

Actually, this does look like the case. See test.py:96

[Aaron Bentley (abentley)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jonathan Lange wrote:
> I remember adding a patch to make sure that DeprecationWarnings didn't
> *fail* the test suite (all warnings fail the LP test suite unless
> explicitly stated otherwise).

I saw this bug:
https://bugs.edge.launchpad.net/launchpad-bazaar/+bug/184958

And it makes it look like you tried to fix it but found it already fixed.

> Actually, this does look like the case. See test.py:96

Well, I'd prefer if deprecation warnings failed the test suite, myself.
 We could then relax it if we had a pressing need. But we might as well
keep in step, and it's easier to know how to cope with a deprecation if
you do it around the time the deprecation was performed, because it's
fresh in someone's mind.

Bzrtools never makes a release whose test suite emits deprecation
warnings, even though they're not considered failures by bzr selftest.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIM8XX0F+nu1YWqI0RAprDAJsH9FZIMtO3xmo3QunZKZ0ktf8RUQCfWnAA
8S/qgyuYqmLK3ZRxB3E/Mws=
=BVbS
-----END PGP SIGNATURE-----

[Jonathan Lange (jml)]

Certainly, I don't think we should maintain deprecation warnings in our suite. However, making deprecation warnings fail the suite makes it more difficult to upgrade Bazaar.

The steps should be:
- Upgrade Bazaar
- Fix deprecation warnings in Launchpad

If deprecation warnings fail, then we are required to:
- Prepare a Launchpad branch that emits no warnings in either version of Bazaar.
- Upgrade Bazaar
- Remove support for older version of Bazaar where it's crufty.

[Aaron Bentley (abentley)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jonathan Lange wrote:
> The steps should be:
> - Upgrade Bazaar
> - Fix deprecation warnings in Launchpad
>
> If deprecation warnings fail, then we are required to:
> - Prepare a Launchpad branch that emits no warnings in either version of Bazaar.
> - Upgrade Bazaar
> - Remove support for older version of Bazaar where it's crufty.

I think you will find that we never deprecate functionality in such a
way that supporting $BAZAAR_CURRENT and $BAZAAR_PREVIOUS is crufty, so
it's just an issue of whether you upgrade Bazaar first or fix
deprecations first.

Frankly, I don't care greatly, I just want to make sure we don't miss
deprecations.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFINBeC0F+nu1YWqI0RAptLAJ4qOBTj2HCUli4m4v0EHdTjCkjdhACePYPJ
EJDTboWhpMmgVkWYYyRCyFQ=
=1/sG
-----END PGP SIGNATURE-----

[Jonathan Lange (jml)]

Definitely a bug, definitely important, fix uncertain.