debdiff shown as html

[Onkar Shinde]

For some time debdiff attached to bug reports are shown as html instead of plain text. This makes it really hard to read it.

Please find attached a screenshot.

Workaround: set the attachment file type manually.

[Diogo Matsubara (matsubara)]

Hi, Onkar,
thanks for the report. Can you point out the bug report where you found that link?

[Onkar Shinde (onkarshinde)]

Diogo,

The bug in question is #227038. The problem is not present now as the type for attachment was changed to text/plain by Michael Bienia (https://edge.launchpad.net/~geser) when he wanted to review it.

As of now I only have one another bug present that has debdiff attached - #229577. The problem is not present there either. So either it has been fixed already on edge or launchpad is assigning text/html type at random.

Hope this helps.

[Diogo Matsubara (matsubara)]

Attaching the debdiff wrongly recognized as html.

[Diogo Matsubara (matsubara)]

Now attaching the same debdiff with the html change inside the diff removed. The code to recognize file type is probably getting confused by the content.

[Sebastien Bacher (seb128)]

the issue happens on a lot of bugs, the changes attached to launchpad bugs are mostly text so maybe that should be default option?

[Gavin Panella (allenap)]

Fixable - though it may not be the best solution - by calling `mimetypes.add_type('text/x-diff', '.debdiff')` at some point before guessing the content type.

[Gavin Panella (allenap)]

This issue could also be solved by adding .debdiff to /etc/mime.types (as equivalent to .diff -> text/x-diff). We'll add a fix to Launchpad in the meantime too.

[Gavin Panella (allenap)]

In RF 6633.

[Gavin Panella (allenap)]

The fix in Launchpad sets the content type of new .debdiff uploads to text/plain, because seb128 discovered that Firefox does not display text/x-diff (which is probably the more appropriate choice of content type for debdiff output) in-browser. Even once /etc/mime.types has been updated (assuming text/x-diff is chosen), we'll keep the text/plain behaviour until Firefox displays text/x-diff in-browser by default, or until it becomes easier (or possible? I couldn't figure out how to change the default) to get Firefox to display it in-browser.

[Matthew Paul Thomas (mpt)]

This appears to be a duplicate of bug 34758.

[Björn Tillenius (bjornt)]

On Sun, Jul 06, 2008 at 04:44:40PM -0000, Matthew Paul Thomas wrote:
> This appears to be a duplicate of bug 34758.

Not quite. This bug has been fixed, while bug 34758 is still unfixed.

[Charles Plessy (plessy)]

Closing in mime-support as the bug was about Launchpad serving the wrong media type.