facet should come from the layer, not __launchpad_facetname__

Bug #226917 reported by Curtis Hovey
12
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

The facet menu works by reading the __launchpad_facetname__ attribute of the view. The publisher adds that attribute to the view if the view does not have it. If the facet menu is passed a context object, there is no view, so there is no facet set.

The attribute is associated with a vhost's request type. That request object has a layer. The facet menu should use the layer associated with the request. We require a mapping or an adapter to convert the layer to a named facet. I image that the LaunchpadRequest's layer is synonymous with the Overview facet in the menu.

Curtis Hovey (sinzui)
Changed in launchpad:
status: New → Confirmed
Changed in launchpad:
importance: Undecided → Medium
Curtis Hovey (sinzui)
tags: added: tech-debt
removed: cleanup
Curtis Hovey (sinzui)
visibility: private → public
description: updated
Curtis Hovey (sinzui)
Changed in launchpad:
importance: Medium → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.