Merge proposal webhooks don't have a scope for comments

Bug #2058348 reported by Giuseppe Barbieri
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Confirmed
Low
Unassigned

Bug Description

The merge proposal webhooks don't really have a scope for comments, so any time something in the merge proposal changes, the webhook is triggered. Ideally we would have more fine grained scopes as it's currently available for bugs webhooks. This might require creating new scope versions for the merge proposal webhooks.

Guruprasad (lgp171188)
tags: added: code-review lp-code
Changed in launchpad:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Ines Almeida (ines-almeida) wrote :

The current merge proposal webhooks are described in https://help.launchpad.net/API/Webhooks#merge-proposal-0.1

Indeed we don't show comments in the payload, but fire it when comments are added - this makes it hard to filter out comment triggers. Changing the scope of `merge-proposal-0.1` is not a good idea because some users of this webhook might already be expecting this behavior for their actions.

Possible solutions:
 - Add a "fields_updated" field to the payload that will help understand what changed that triggered the webhook
 - Create a new scope version for merge proposals (`merge-proposal-0.2`) that is more fine grained, and eventually one for comments specifically (`merge-proposal-comments-0.2`)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.