| 2023-08-11 17:00:14 |
Steve Beattie |
description |
Please see https://code.launchpad.net/~pfsmorigo/ubuntu-cve-tracker/+git/ubuntu-cve-tracker/+merge/448821 for an example of this.
The launchpad merge reuqest interface becomes confused when an emailed reply to the merge request includes a patch as an attachment. In the example request above, Emi Torino's comments were made against the preview diff. However, when I sent a response that included an attached patch that I felt should be included as part of the merge, the interface correctly identified that it was a patch/diff and tried to treat it as such, but then adjusted Emi's inline comments to make them appear that she was commenting on the emailed patch. The emailed reply was not in response to her comments, but to the initial merge request email (though the response was sent after the inline comments were made, and the associated email for them was received). |
Please see https://code.launchpad.net/~pfsmorigo/ubuntu-cve-tracker/+git/ubuntu-cve-tracker/+merge/448821 for an example of this.
The launchpad merge request interface becomes confused when an emailed reply to the merge request includes a patch as an attachment. In the example request above, Emi Torino's comments were made against the preview diff. However, when I sent a response that included an attached patch that I felt should be included as part of the merge, the interface correctly identified that it was a patch/diff and tried to treat it as such, but then adjusted Emi's inline comments to make them appear that she was commenting on the emailed patch. The emailed reply was not in response to her comments, but to the initial merge request email (though the response was sent after the inline comments were made, and the associated email for them was received). |
|
