Diff comments in merge proposals get lost if not explicitly saved

Bug #2003721 reported by Maximiliano Bertacchini
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

Inline diff comments in MPs have each their own Save/Cancel actions, separate from the main "Save comment" action at the top. This "Save" duplicity might be confusing and cause loss of inline comments, as the user might save the main comment expecting diff comments to be included - but they're dropped without warning. In such case I'd suggest saving inline comments automatically, or at least show a warning about unsaved diff comments.

Tags: code-review ui
description: updated
Revision history for this message
Jürgen Gmach (jugmac00) wrote :

A warning sounds appropriate.

Changed in launchpad:
status: New → Triaged
importance: Undecided → Low
tags: added: code-review ui
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.