MPs do not show all replacement commits following a force push

Bug #1979673 reported by Robie Basak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

If I force push to the source branch of an existing MP, then some new commits are displayed, but not all of them.

For example, in https://code.launchpad.net/~racb/git-ubuntu/+git/usd-importer/+merge/424877, I force pushed an entire replacement branch since I amended the first commit of a series of commits. But the MP mentions only the addition of a single commit.

It happens that my replacement branch contains one additional commit. Did Launchpad just count the commits and assume that I only added on to the end?

Expected result: the entire set of replacement commits are presented in the history. Perhaps, if commits have disappeared as well as new ones being added, this should be mentioned, too.

I found I'd already filed bug 1849306 which is related, but this issue is that what is already being presented is misleading, whereas the other is a request to improve UX in case of a force push.

Revision history for this message
Jürgen Gmach (jugmac00) wrote :

Thanks for this detailed report.

We had a quick look at it, and there might be an issue in the implementation for comment/commit interleaving.

Changed in launchpad:
status: New → Triaged
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.