Widen GitRepository rescan permissions slightly
Bug #1933971 reported by
Colin Watson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Ioana Lasc | ||
Bug Description
The Rescan button on git repositories and git-based merge proposals requires `launchpad.Edit` on the repository, which can only be used by repository owners. We do need some limits to avoid trivial denial-of-service attacks, but we could open it up at least to `launchpad.
For extra credit, we might also reasonably allow anyone with any kind of per-ref permission on the repository to rescan it.
Related branches
~ilasc/launchpad:bug-1933971
- Colin Watson (community): Approve
-
Diff: 133 lines (+74/-9)4 files modifiedlib/lp/code/browser/configure.zcml (+1/-1)
lib/lp/code/browser/tests/test_gitrepository.py (+48/-0)
lib/lp/code/interfaces/gitrepository.py (+8/-8)
lib/lp/code/model/tests/test_gitrepository.py (+17/-0)
| summary: |
- Widen rescan permissions slightly + Widen GitRepository rescan permissions slightly |
| Changed in launchpad: | |
| status: | Triaged → Fix Released |
| assignee: | nobody → Ioana Lasc (ilasc) |
To post a comment you must log in.
