answers.launchpad.net timestamp of changes of comment shown in wrong time zone
Bug #1933079 reported by
Manfred Hampl
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Colin Watson |
Bug Description
answers.
The timestamps of the previous versions, however, are not displayed in the time zone defined in the user preferences, but apparently are shown in local time.
Example taken from https:/
Related branches
~cjwatson/launchpad:message-revisions-time-rendering
Merged
into
launchpad:master
- Cristian Gonzalez (community): Approve
-
Diff: 269 lines (+51/-29)9 files modifiedlib/lp/answers/templates/questionmessage-display.pt (+1/-1)
lib/lp/bugs/templates/bugcomment-box.pt (+1/-1)
lib/lp/code/templates/codereviewcomment-header.pt (+1/-1)
lib/lp/services/messages/interfaces/messagerevision.py (+7/-0)
lib/lp/services/messages/javascript/messages.edit.js (+0/-2)
lib/lp/services/messages/javascript/tests/test_messages.edit.html (+2/-2)
lib/lp/services/messages/javascript/tests/test_messages.edit.js (+3/-5)
lib/lp/services/messages/model/messagerevision.py (+5/-0)
lib/lp/services/messages/tests/test_messagerevision.py (+31/-17)
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Colin Watson (cjwatson) |
Changed in launchpad: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
I remarked on this in a parenthetical comment on https:/ /code.launchpad .net/~pappacena /launchpad/ +git/launchpad/ +merge/ 403213 (under the first "Show diff comments"), but hadn't been thinking about the possibility of the user's configured time zone in LP differing from their browser's time zone. I agree that this is a good reason to just have the webapp render the timestamp.