OOPS on MP pages when Turnip is not fully available
Bug #1923895 reported by
Alexandre Gomes
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Thiago F. Pappacena |
Bug Description
When accessing https:/
The most recent OOPS-ids are:
OOPS-4585acd8c565e9d771b16f424adb08a8
OOPS-042d3538df640493fe89b3ba0b573477
Related branches
~pappacena/launchpad:gitref-and-mp-pages-without-oops-on-failure
Merged
into
launchpad:master
- Colin Watson (community): Approve
- Ioana Lasc (community): Approve
-
Diff: 329 lines (+124/-11)6 files modifiedlib/lp/code/browser/branchmergeproposal.py (+37/-1)
lib/lp/code/browser/gitref.py (+33/-5)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+22/-4)
lib/lp/code/browser/tests/test_gitref.py (+26/-1)
lib/lp/code/templates/branchmergeproposal-index.pt (+3/-0)
lib/lp/code/templates/git-macros.pt (+3/-0)
Changed in launchpad: | |
assignee: | nobody → Thiago F. Pappacena (pappacena) |
Changed in launchpad: | |
status: | Triaged → In Progress |
Changed in launchpad: | |
status: | In Progress → Fix Committed |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The page is OOPSing when Launchpad tries to get git log from Turnip, which returns a 500 error.
The information that comes from Turnip to fill MP page is not totally necessary. The user should be able to see the MP page, even if some information from Turnip is not immediately available.