Better merge proposal review comment handling

Bug #1923530 reported by Joel Sing on 2021-04-13
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Low
Unassigned

Bug Description

The handling of review comments on merge proposals is currently rather obscure - as soon as a new revision is pushed to the repository, all of the existing comments disappear from view unless you either click on 'show comments' associated with the review comment, or manually select the previous revision from the drop down list (and if there are multiple you get to guess which one has the comments on it).

It would be helpful if Launchpad made it far more obvious that comments exist on the merge proposal and provide better ways from locating these.

Additionally, being able to mark comments as having been 'resolved' and keeping them visible when they are not (e.g. "this merge proposal still has X unresolved comments") would be a significant improvement to author/reviewer workflow.

Haw Loeung (hloeung) on 2021-04-13
Changed in launchpad:
status: New → Confirmed
Colin Watson (cjwatson) on 2021-04-13
tags: added: code-review confusing-ui inline-comments lp-code
Changed in launchpad:
status: Confirmed → Triaged
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers