Automatically merge MPs with "Status" set to "Approved"

Bug #1922156 reported by Haw Loeung
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

Hi,

Any chance of having Launchpad merge MPs with "Status" set to "Approved"?

We're currently doing this via our own "mergebot" but would be nice if LP could do this for us.

Revision history for this message
Colin Watson (cjwatson) wrote :

We can't do this as such because some other teams have workflows that use Approved as an indication that a merge bot should run tests and then merge if they pass. Having LP do the merge directly would bypass those teams' CI processes.

I'd definitely like us to have something that doesn't require external bots, but it will likely require working out a way to attach test results to merge proposals first.

Changed in launchpad:
status: New → Triaged
importance: Undecided → Low
tags: added: code-review lp-code
Revision history for this message
Joel Sing (jsing) wrote :

It seems like this would be easily achieved via a separate 'merge' button and/or a 'approve and merge' state (CI systems could then also set 'approve and merge' following a successful run on 'approve'). Alternatively, having configuration that allows a specific repo to be configured for 'merge when changes are approved' would mean that people who do not rely on 'approved' for CI workflow could benefit from this sooner rather than later.

Revision history for this message
Colin Watson (cjwatson) wrote :

We'd like to do a merge button, but as I say it's our assessment that it would be best to have a way to attach test results to merge proposals first in order that it doesn't encourage people to merge untested code unnecessarily.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.