Flag or status for "Needs Review" for merge proposals
Bug #1922154 reported by
Haw Loeung
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Triaged
|
Low
|
Unassigned | ||
Bug Description
Hi,
In the past, we've (Canonical IS) been incorrectly using the "Resubmit" flag when we want MPs to be re-reviewed. So an MP gets reviewed, the reviewer marks it as "Needs Fixing", the submitter makes fixes and pushes those. Then the only way to have it appear to be ready for another round of reviews is to mark it as "Resubmit".
Any chance we could get a flag to specifically request or state that an MP is ready for reviewing again?
Maybe also clear the "Needs fixing" status so it's easily visible which MPs are ready for reviewing in the `+activereviews` page?
| https:/
Revision history for this message
| Colin Watson (cjwatson) wrote | #1 |
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| tags: | added: code-review lp-code |
To post a comment you must log in.
I'm not sure what the best way to do this would be - we'll need to consider our options. I don't think it should be another flag as such, but maybe the submitter should be able to clear an existing vote and set it back to Pending, or something like that.