OCI registry upload status should be on the front page of the recipe

[Tom Wardill]

The registry upload status for a recipe build is currently only visible on the build page.
It would be more useful if this was also exposed on the front page of the recipe, next to where it says 'successfully built'.

Also add information to say the upload can be retried once the push rule is updated.

[Colin Watson (cjwatson)]

I agree - the comparison here should be with Archive:+packages for PPAs, where the summary presentation of a set of builds distinguishes between "All builds were built successfully but have not yet been published" (using the "build-success-publishing" icon) and "All builds were built successfully" (using the "yes" icon).

I'd suggest reusing BuildSetStatus for this, since it's generic enough to be usable even if the details of publishing differ.

https://bugs.launchpad.net/launchpad/+bug/1634209 is the equivalent bug for snaps.

[Sergio Durigan Junior (sergiodj)]

Thanks for the hard work, guys. The new page looks much better and more informative than the previous one, but I have a comment about the new "Upload status" column. It appears that when one or more architectures fail to build the image, the column shows "No registry upload requested." However, that's not entirely true: the successful builds are uploaded normally. Perhaps the column should say something like "Some builds uploaded successfully"? I'm just concerned that saying "No registry upload requested" might hide problems if/when an upload goes wrong for an image that was successfully built.

Reference: https://launchpad.net/~ubuntu-docker-images/ubuntu-docker-images/+oci/grafana/+recipe/grafana-21.04

[Tom Wardill (twom)]

Yep, that's a bug in the set handling, thanks for reporting.

Filed as https://bugs.launchpad.net/launchpad/+bug/1925763 and I'll have a look at it