Launchpad itself

Regression: "expand all" on a revision for a bzr branch does nothing

Bug #1894738 reported by Olivier Tilloy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Tom Wardill
loggerhead
Fix Released
Undecided
Tom Wardill

Bug Description

This is a fairly recent regression in launchpad/loggerhead (maybe a couple months old).
When browsing a given revision in a bzr branch (for instance https://bazaar.launchpad.net/~loggerhead-team/loggerhead/trunk-rich/revision/509), the "expand all"/"collapse all" link does nothing. When clicking it, I'm seeing this in the web console:

  diff.js:125 Uncaught TypeError: Cannot read property 'open' of undefined
    at HTMLDivElement.<anonymous> (diff.js:125)
    at Function.each (jquery.min.js:2)
    at k.fn.init.each (jquery.min.js:2)
    at toggle_expand_all_revisionview (diff.js:111)
    at HTMLAnchorElement.<anonymous> (diff.js:135)
    at HTMLAnchorElement.dispatch (jquery.min.js:2)
    at HTMLAnchorElement.v.handle (jquery.min.js:2)

See original description

Related branches

lp:~twom/loggerhead/animation-binding
Colin Watson (community): Approve
Diff: 52 lines (+5/-5)
2 files modified
loggerhead/static/javascript/custom.js (+4/-4)
loggerhead/static/javascript/diff.js (+1/-1)
lp:~twom/loggerhead/javascript-context-selector
Colin Watson (community): Approve
Diff: 44 lines (+6/-6)
1 file modified
loggerhead/static/javascript/diff.js (+6/-6)
lp:~twom/loggerhead/side-by-side-js-fix
Colin Watson (community): Approve
Diff: 129 lines (+21/-19)
1 file modified
loggerhead/static/javascript/diff.js (+21/-19)
~twom/launchpad:loggerhead-upgrade=511
Ioana Lasc (community): Approve
Diff: 26 lines (+3/-3)
2 files modified
utilities/sourcedeps.cache (+2/-2)
utilities/sourcedeps.conf (+1/-1)
Olivier Tilloy (osomon)
description: updated
Tom Wardill (twom)
Changed in launchpad:
assignee: nobody → Tom Wardill (twom)
Changed in loggerhead:
assignee: nobody → Tom Wardill (twom)
Tom Wardill (twom)
Changed in launchpad:
status: New → In Progress
Changed in loggerhead:
status: New → In Progress
Revision history for this message
Olivier Tilloy (osomon) wrote :

Thanks for working on this Tom!

Revision history for this message
Tom Wardill (twom) wrote :

No problems, looks like some fallout from recently moving to jQuery instead of YUI. Sorry it broke things!

Tom Wardill (twom)
Changed in launchpad:
status: In Progress → Fix Committed
Changed in loggerhead:
status: In Progress → Fix Committed
Ioana Lasc (ilasc)
Changed in launchpad:
status: Fix Committed → Fix Released
Tom Wardill (twom)
Changed in loggerhead:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.