MPs do not show changes introduced by a force push

Bug #1849306 reported by Robie Basak on 2019-10-22
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Undecided
Unassigned

Bug Description

A common workflow used by developers using git is to present a patch set for review as a branch, which we commonly do in Launchpad using merge proposals. After review feedback, the development team may choose to rebase the branch instead of adding commits to the end, depending on their preferences and the suitability of this to the specific review changes.

Currently this works in Launchpad: the proposer does a "force push" and the preview diff and commits then show the new proposal.

However what is missing is to show the reviewer what changed since the previous version of the proposal when this workflow is being used.

"git range-diff", available since git 2.19 (for Ubuntu, >= Disco), is great at showing how a patchset has been changed. One way of resolving this bug would be to have Launchpad make available for viewing the fully colorised "git range-diff" output for each successive non-fast-forwarding push made to an MP's source branch. A further nice enhancement would be to permit inline reviews of this output.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers