uploads with null characters in debian/copyright get rejected
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Tom Wardill |
Bug Description
<doko> Rejected:
<doko> A string literal cannot contain NUL (0x00) characters.
<doko> emscripten (1.22.1-1build2) eoan; urgency=medium
<doko> but where is that char?
<cjwatson> The copyright file I believe
<cjwatson> doko: It looks like data corruption on line 6324 of debian/copyright FWIW
<cjwatson> Files: tests/sdl_
<cjwatson> ./tests/
<cjwatson> Copyright: D<80>^@^A^B^D^H^Ph, `5^NÏè^D^H^P @<80>@M^
<cjwatson> says vim
<doko> yep
<cjwatson> Maybe auto-extracted by something that ended up dumping in binary data or something
<doko> and removed in Debian
<doko> ahh, no, my bad
<cjwatson> Yes, that string is auto-extracted - it appears at byte position 2256 of tests/sdl_
<cjwatson> Immediately after something that happens to be "©" :-)
<cjwatson> (i.e. U+00A9 COPYRIGHT SIGN)
Related branches
- Colin Watson (community): Approve
-
Diff: 63 lines (+18/-2)3 files modifiedlib/lp/soyuz/model/sourcepackagerelease.py (+5/-0)
lib/lp/soyuz/tests/test_sourcepackagerelease.py (+7/-0)
lib/lp/testing/factory.py (+6/-2)
Changed in launchpad: | |
status: | New → In Progress |
assignee: | nobody → Tom Wardill (twom) |
tags: | added: lp-soyuz soyuz-upload |
Changed in launchpad: | |
importance: | Undecided → High |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Traceback (most recent call last): .net/production /launchpad- rev-19044/ lib/lp/ archiveuploader /nascentupload. py", line 710, in do_accept storeObjectsInD atabase( build=build) .net/production /launchpad- rev-19044/ lib/lp/ archiveuploader /nascentupload. py", line 812, in storeObjectsInD atabase gerelease = self.changes. dsc.storeInData base(build) .net/production /launchpad- rev-19044/ lib/lp/ archiveuploader /dscfile. py", line 721, in storeInDatabase buildinfo_ lfa, .net/production /launchpad- rev-19044/ lib/lp/ registry/ model/distroser ies.py" , line 1215, in createUploadedS ourcePackageRel ease buildinfo) .net/production /launchpad- rev-19044/ lib/lp/ soyuz/model/ sourcepackagere lease.py" , line 147, in __init__ .net/production /launchpad- rev-19044/ lib/lp/ soyuz/model/ sourcepackagere lease.py" , line 173, in copyright .net/production /launchpad- rev-19044/ env/local/ lib/python2. 7/site- packages/ storm/store. py", line 109, in execute n.execute( statement, params, noresult) .net/production /launchpad- rev-19044/ env/local/ lib/python2. 7/site- packages/ storm/databases /postgres. py", line 306, in execute execute( self, statement, params, noresult) .net/production /launchpad- rev-19044/ env/local/ lib/python2. 7/site- packages/ storm/database. py", line 241, in execute execute( statement, params) .net/production /launchpad- rev-19044/ env/local/ lib/python2. 7/site- packages/ storm/databases /postgres. py", line 316, in raw_execute raw_execute( self, statement, params) .net/production /launchpad- rev-19044/ env/local/ lib/python2. 7/site- packages/ storm/database. py", line 372, in raw_execute _prepare_ execution( raw_cursor, params, statement) .net/production /launchpad- rev-19044/ env/local/ lib/python2. 7/site- packages/ storm/database. py", line 404, in _prepare_execution .net/production /launchpad- rev-19044/ env/local/ lib/python2. 7/site- packages/ storm/database. py", line 454, in _check_disconnect .net/production /launchpad- rev-19044/ env/local/ lib/python2. 7/site- packages/ storm/tracer. py", line 248, in trace .net/production /launchpad- rev-19044/ lib/lp/ services/ webapp/ adapter. py", line 684, in connection_ raw_execute n.to_database( params) ))
File "/srv/launchpad
self.
File "/srv/launchpad
sourcepacka
File "/srv/launchpad
buildinfo=
File "/srv/launchpad
buildinfo=
File "/srv/launchpad
self.copyright = copyright
File "/srv/launchpad
(content, self.id))
File "/srv/launchpad
return self._connectio
File "/srv/launchpad
return Connection.
File "/srv/launchpad
raw_cursor = self.raw_
File "/srv/launchpad
return Connection.
File "/srv/launchpad
self.
File "/srv/launchpad
statement, params or ())
File "/srv/launchpad
return function(*args, **kwargs)
File "/srv/launchpad
attr(*args, **kwargs)
File "/srv/launchpad
statement, tuple(connectio
ValueError: A string literal cannot contain NUL (0x00) characters.