Launchpad itself

requestAutoBuilds crashes for snaps configured to detect distro_series

Bug #1817544 reported by William Grant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
William Grant

Bug Description

When a snap is configured to automatically detect its distroseries from the snapcraft.yaml "base" field, requestAutoBuilds as called by request_daily_builds.py crashes:

IncompatibleArguments: Cannot use requestAutoBuilds for a snap package without distro_series being set. Consider using requestBuilds instead.

This should probably check "not fetch_snapcraft_yaml and self.distro_series is None" instead, as distroseries can be inferred now.

Related branches

lp:~wgrant/launchpad/bug-1817544-makeAutoBuilds-infer
William Grant: Approve (code)
Diff: 52 lines (+26/-3)
2 files modified
lib/lp/snappy/model/snap.py (+3/-3)
lib/lp/snappy/tests/test_snap.py (+23/-0)
William Grant (wgrant)
Changed in launchpad:
assignee: nobody → William Grant (wgrant)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r18887 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/18887>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.