Purpose of "Renew their membership automatically" is unclear
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Unassigned |
Bug Description
Steve and I have been discussing this option that a team maintainer can set: "When someone's membership is about to expire, Launchpad should notify them and: (*) renew their membership automatically, also notifying the admins". At face value, this seems like a complicated way of doing nothing: Launchpad lets you set a time period after which memberships not-expire, and e-mails you to let you know that it's not-expired them.
The option might exist to remind team admins of who is a member of their teams, without actually expiring them. But if so, this could be implemented in a way that didn't mention the word "expire" at all.
Another possible purpose is to let someone sign up to teams knowing that Launchpad will remind them of the membership at regular intervals, to prompt them to unsubscribe if they are no longer interested. (Like how Mailman reminds people of what mailing lists they're subscribed to.) But this would work only if it was an option members could set for all teams they're a member of, rather than an option admins could set for individual teams.
I suggest that the "renew their membership automatically" option be removed, or if necessary replaced by a separate option that addresses the relevant use case without referring to memberships expiring.
Related branches
- William Grant: Approve (code)
-
Diff: 775 lines (+44/-391)15 files modifiedcronscripts/flag-expired-memberships.py (+1/-1)
lib/lp/registry/browser/team.py (+6/-0)
lib/lp/registry/browser/tests/private-team-creation-views.txt (+9/-9)
lib/lp/registry/configure.zcml (+1/-2)
lib/lp/registry/doc/teammembership-email-notification.txt (+0/-90)
lib/lp/registry/doc/teammembership.txt (+0/-90)
lib/lp/registry/emailtemplates/membership-auto-renewed-bulk.txt (+0/-7)
lib/lp/registry/emailtemplates/membership-auto-renewed-personal.txt (+0/-7)
lib/lp/registry/interfaces/person.py (+4/-16)
lib/lp/registry/interfaces/teammembership.py (+5/-13)
lib/lp/registry/model/teammembership.py (+2/-66)
lib/lp/registry/stories/teammembership/xx-member-renewed-membership.txt (+6/-7)
lib/lp/registry/stories/teammembership/xx-teammembership.txt (+0/-55)
lib/lp/registry/tests/test_team.py (+8/-13)
lib/lp/registry/tests/test_teammembership.py (+2/-15)
Changed in launchpad-registry: | |
importance: | Undecided → Low |
status: | New → Triaged |
tags: |
added: teams removed: registry |
Changed in launchpad: | |
assignee: | nobody → Curtis Hovey (sinzui) |
Changed in launchpad: | |
status: | Triaged → In Progress |
tags: | added: disclosure privacy-transitions |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Changed in launchpad: | |
assignee: | Curtis Hovey (sinzui) → nobody |
Only 25 teams use "Renew their membership automatically", and 5 of them have set the times to be 3-10 years in the future. I think users are trying to ensure users do not need to leave the team, but it was not clear that Lp will not expire membership if the "Subscription Period" (very bad label) is empty or 0.
Let's remove this option from the form next time we visit this form.