Fetching snapcraft.yaml from GitHub doesn't honour symlinks

Bug #1797366 reported by Colin Watson
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Colin Watson

Bug Description

build.snapcraft.io is currently failing to request snap builds from https://github.com/hughsie/fwupd. This is because snap/snapcraft.yaml is a symlink, and so:

  $ curl https://raw.githubusercontent.com/hughsie/fwupd/HEAD/snap/snapcraft.yaml
  ../contrib/snap/snapcraft-stable.yaml

We may need to use the contents API (https://developer.github.com/v3/repos/contents/#get-contents) instead. I'd been avoiding this in order to avoid having to worry about rate-limiting, but I don't see another way.

Tags: lp-code qa-ok

Related branches

Revision history for this message
Mario Limonciello (superm1) wrote :

Thanks for debugging and confirming. At least for now I'll swap that file to be a real file rather than symlink to get this working again.

When this is sorted I would like to go back to symlink though.

Revision history for this message
William Grant (wgrant) wrote :

We could just see if it looks like a path and resolve it ourselves.

Revision history for this message
Colin Watson (cjwatson) wrote :

Bug 1832212 is slightly related, although not a dependency.

Colin Watson (cjwatson)
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Colin Watson (cjwatson)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Colin Watson (cjwatson)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers