Launchpad itself

Unable to delete repository

Bug #1793266 reported by Alkis Georgopoulos
32
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Colin Watson

Bug Description

Hi, I go to https://code.launchpad.net/~alkisg/epoptes/+git/gsoc2018/+delete
I press the Delete button,
but I keep getting the following error:

Timeout error
Sorry, something just went wrong in Launchpad.
We’ve recorded what happened, and we’ll fix it as soon as possible. Apologies for the inconvenience.
Trying again in a couple of minutes might work.
(Error ID: OOPS-e9f7efb3ba3a49bef6802a1856978481)

...please delete that repository for me. Thank you.

See original description

Related branches

lp:~cjwatson/launchpad/db-code-async-delete
William Grant (community): Approve (db)
Stuart Bishop: Pending (db) requested
Diff: 16 lines (+12/-0)
1 file modified
database/schema/patch-2210-01-0.sql (+12/-0)
lp:~cjwatson/launchpad/code-delete-no-recipe-preload
William Grant (community): Approve (code)
Diff: 138 lines (+19/-12)
6 files modified
lib/lp/code/browser/branch.py (+1/-1)
lib/lp/code/browser/gitrepository.py (+2/-1)
lib/lp/code/interfaces/branch.py (+3/-1)
lib/lp/code/interfaces/gitrepository.py (+3/-1)
lib/lp/code/model/branch.py (+5/-4)
lib/lp/code/model/gitrepository.py (+5/-4)
lp:~cjwatson/launchpad/branch-delete-job
Rejected for merging into lp:launchpad
Launchpad code reviewers: Pending requested
Diff: 948 lines (+377/-48)
11 files modified
database/schema/security.cfg (+48/-0)
lib/lp/code/configure.zcml (+10/-1)
lib/lp/code/enums.py (+12/-1)
lib/lp/code/interfaces/branch.py (+7/-1)
lib/lp/code/interfaces/branchjob.py (+19/-1)
lib/lp/code/model/branch.py (+19/-1)
lib/lp/code/model/branchjob.py (+84/-3)
lib/lp/code/model/tests/test_branch.py (+76/-38)
lib/lp/code/model/tests/test_branchjob.py (+95/-2)
lib/lp/code/stories/webservice/xx-branch.txt (+1/-0)
lib/lp/services/config/schema-lazr.conf (+6/-0)
lp:~cjwatson/launchpad/git-repository-delete-job
Rejected for merging into lp:launchpad
Launchpad code reviewers: Pending requested
Diff: 752 lines (+317/-33)
10 files modified
database/schema/security.cfg (+7/-0)
lib/lp/code/configure.zcml (+9/-0)
lib/lp/code/enums.py (+12/-0)
lib/lp/code/interfaces/gitjob.py (+22/-1)
lib/lp/code/interfaces/gitrepository.py (+6/-0)
lib/lp/code/model/gitjob.py (+73/-0)
lib/lp/code/model/gitrepository.py (+18/-0)
lib/lp/code/model/tests/test_gitjob.py (+104/-0)
lib/lp/code/model/tests/test_gitrepository.py (+60/-32)
lib/lp/services/config/schema-lazr.conf (+6/-0)
lp:~cjwatson/launchpad/code-async-delete
Rejected for merging into lp:launchpad
Launchpad code reviewers: Pending requested
Diff: 704 lines (+350/-25)
15 files modified
lib/lp/code/browser/branch.py (+8/-4)
lib/lp/code/browser/gitrepository.py (+6/-2)
lib/lp/code/browser/tests/test_gitrepository.py (+20/-0)
lib/lp/code/interfaces/branch.py (+17/-4)
lib/lp/code/interfaces/gitrepository.py (+18/-5)
lib/lp/code/model/branch.py (+21/-2)
lib/lp/code/model/gitrepository.py (+17/-6)
lib/lp/code/model/tests/test_branch.py (+30/-0)
lib/lp/code/model/tests/test_gitrepository.py (+25/-0)
lib/lp/code/stories/branches/xx-branch-deletion.txt (+14/-0)
lib/lp/code/stories/webservice/xx-branch.txt (+14/-1)
lib/lp/code/templates/branch-index.pt (+4/-0)
lib/lp/code/templates/gitrepository-index.pt (+7/-0)
lib/lp/scripts/garbo.py (+65/-0)
lib/lp/scripts/tests/test_garbo.py (+84/-1)
Alkis Georgopoulos (alkisg)
description: updated
Revision history for this message
Alkis Georgopoulos (alkisg) wrote :

Hi, I tried again today, still the same issue, that repository isn't deleteable and needs to be removed manually by some administrator.

Colin Watson (cjwatson)
tags: added: git lp-code oops timeout
Revision history for this message
Colin Watson (cjwatson) wrote :

It's odd that the delete from Job is so slow, since selecting from it is quite quick on staging. Perhaps there are some badly organised indexes or something.

If we can't fix the delete to be fast, we may have to invent a "deleting" status for Git repositories, and then make this asynchronous.

Changed in launchpad:
importance: Undecided → Critical
status: New → Triaged
Colin Watson (cjwatson)
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Colin Watson (cjwatson)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r14049 in db-stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/14049) is part of this bug's fix.

tags: added: qa-needstesting
Revision history for this message
Colin Watson (cjwatson) wrote :

2019-03-22 18:02:54,291 INFO 2210-01-0 applied just now in 0.1 seconds

tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r18920 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/18920) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Colin Watson (cjwatson)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Colin Watson (cjwatson) wrote :

Could you please give this another try? We may still need the asynchronous deletion, but in the meantime we added some more database indexes yesterday (https://code.launchpad.net/~cjwatson/launchpad/more-job-indexes/+merge/367063) which may well have helped.

Revision history for this message
Denis Smirnov (dennwc) wrote :

It fixed the issue for me, thanks!

Revision history for this message
Alkis Georgopoulos (alkisg) wrote :

I tried it on two repositories that I couldn't delete.
Both were imports of external repositories.

Both were successfully deleted just now!
Thanks a lot!

Revision history for this message
René Fritze (renemilk) wrote :

I can also confirm this working on a previously failing repo: https://code.launchpad.net/~pymor/pymor/+git/pymor

Revision history for this message
Colin Watson (cjwatson) wrote :

It sounds like the indexes did the trick. If we come across new cases where deletion performance is a problem, please file a new bug and we can look into it there.

Changed in launchpad:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Related questions

Remote bug watches

Bug watches keep track of this bug in other bug trackers.