GitRepository:++repository-pending-merges does not preload review comments
Bug #1791668 reported by
Tom Wardill
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Colin Watson | ||
Bug Description
As seen in OOPS-d8dd9b06d9767a7e11ac139affc02f20.
GitRepository:
This can scale badly if it's a series of very active merges.
Related branches
lp:~cjwatson/launchpad/git-pending-merges-preload-messages
- Tom Wardill (community): Approve
- Launchpad code reviewers: Pending requested
-
Diff: 98 lines (+26/-7)2 files modifiedlib/lp/code/browser/tests/test_gitrepository.py (+15/-2)
lib/lp/code/model/branchmergeproposal.py (+11/-5)
| description: | updated |
| tags: | added: fallout git lp-code |
| Changed in launchpad: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Colin Watson (cjwatson) |
| summary: |
- GitRepository:++repository-pending-merges does not preload Votes or - Voters + GitRepository:++repository-pending-merges does not preload review + comments |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r18773 <http://