code.launchpad.net links do not handle pound (#) in git branch name
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Colin Watson |
Bug Description
Consider the following (legal) bit branch name and status:
~/projects/
On branch allow_charon_
$ git remote -v
origin git://git.
origin git://git.
staging git+ssh://<email address hidden>
staging git+ssh://<email address hidden>
Directly viewing the git views, links work fine:
https:/
, https:/
, https:/
However, when viewing from the "code", the "#" does not get converted to %23.
https:/
For example:
- https:/
, see this:
{{{
Branches
Name Last Modified Last Commit
allow_charon_
As per LP #1786250, user noted audit failures in system log
LINKS TO: --> https:/
}}}
whoops,
{{{
Lost something?
This page does not exist, or you may not have permission to see it.
}}}
it needs to link to:
-> https:/
Related branches
- William Grant (community): Approve (code)
-
Diff: 211 lines (+70/-8)8 files modifiedlib/lp/code/browser/configure.zcml (+1/-1)
lib/lp/code/browser/tests/test_gitlisting.py (+8/-2)
lib/lp/code/browser/tests/test_gitref.py (+35/-2)
lib/lp/code/browser/tests/test_gitrepository.py (+5/-0)
lib/lp/code/interfaces/gitref.py (+2/-0)
lib/lp/code/model/gitref.py (+5/-0)
lib/lp/testing/publication.py (+3/-2)
lib/lp/testing/tests/test_publication.py (+11/-1)
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Nicely spotted. Most of the things we put into Launchpad URLs have very restricted syntax such that they don't require quoting, but ref names are indeed an exception here.