UnicodeDecodeError when mailing git review comment

Bug #1787587 reported by Iain Lane on 2018-08-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Critical
Colin Watson

Bug Description

I reviewed https://code.launchpad.net/~3v1n0/ubuntu/+source/gnome-session/+git/gnome-session/+merge/353283 and posted an inline comment. A little while later I was mailed an OOPS saying that the review couldn't be sent: https://oops.canonical.com/?oopsid=OOPS-a17335a54b5fe4461f4e675604a9a1bb

  UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 33: ordinal not in range(128)

    Traceback (most recent call last):
  Module lazr.jobrunner.jobrunner, line 194, in runJobHandleError
    self.runJob(job, fallback)
  Module lp.services.job.runner, line 316, in runJob
    super(BaseJobRunner, self).runJob(IRunnableJob(job), fallback)
  Module lazr.jobrunner.jobrunner, line 162, in runJob
    job.run()
  Module lp.code.model.branchmergeproposaljob, line 401, in run
    mailer = CodeReviewCommentMailer.forCreation(self.code_review_comment)
  Module lp.code.mail.codereviewcomment, line 87, in forCreation
    code_review_comment.message.rfc822msgid)
  Module lp.code.mail.codereviewcomment, line 77, in __init__
    self._generateBodyBits()
  Module lp.code.mail.codereviewcomment, line 113, in _generateBodyBits
    inline_comment.comments, inline_comment.previewdiff.text)
  Module lp.code.mail.codereviewcomment, line 239, in build_inline_comments_section
    hunk_lines.append(u'> %s' % hunk.get_header().rstrip('\n'))
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 33: ordinal not in range(128)

Looks similar to bug #1319124 but that one's fixed.

Related branches

Colin Watson (cjwatson) on 2018-08-17
tags: added: code-review email inline-comments lp-code oops
Changed in launchpad:
status: New → In Progress
importance: Undecided → Critical
assignee: nobody → Colin Watson (cjwatson)
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Colin Watson (cjwatson) on 2018-08-20
tags: added: qa-ok
removed: qa-needstesting
Colin Watson (cjwatson) on 2018-08-24
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers