build.snapcraft.io uses snapcraft from the deb archive
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Colin Watson | ||
launchpad-buildd |
Fix Released
|
High
|
Colin Watson |
Bug Description
snapcraft is now available in the stable channel. We should probably switch to using the snap of snapcraft
alan@deep-
name: snapcraft
summary: easily create snaps
publisher: canonical
contact: <email address hidden>
description: |
Snapcraft aims to make upstream developers' lives easier and as such is not a
single toolset, but instead is a collection of tools that enable the natural
workflow of an upstream to be extended with a simple release step into Snappy
enabled system.
snap-id: vMTKRaLjnOJQetI
commands:
- snapcraft
tracking: edge
installed: 2.37+git3.1a7a4f7 (938) 53MB classic
refreshed: 2017-12-11 23:44:28 +0000 UTC
channels:
stable: 2.35 (794) 53MB classic
candidate: ↑
beta: 2.37 (924) 53MB classic
edge: 2.37+git3.1a7a4f7 (938) 53MB classic
Related branches
- William Grant (community): Approve (code)
-
Diff: 215 lines (+82/-9)6 files modifieddebian/changelog (+10/-0)
lpbuildd/snap.py (+11/-0)
lpbuildd/target/build_snap.py (+19/-1)
lpbuildd/target/lxd.py (+9/-1)
lpbuildd/target/tests/test_build_snap.py (+25/-4)
lpbuildd/target/tests/test_lxd.py (+8/-3)
- William Grant (community): Approve (db)
-
Diff: 16 lines (+12/-0)1 file modifieddatabase/schema/patch-2209-83-1.sql (+12/-0)
- William Grant (community): Approve (code)
-
Diff: 512 lines (+177/-25)9 files modifiedlib/lp/snappy/interfaces/snap.py (+22/-3)
lib/lp/snappy/interfaces/snapbuild.py (+9/-1)
lib/lp/snappy/model/snap.py (+22/-10)
lib/lp/snappy/model/snapbuild.py (+7/-3)
lib/lp/snappy/model/snapbuildbehaviour.py (+3/-1)
lib/lp/snappy/tests/test_snap.py (+93/-1)
lib/lp/snappy/tests/test_snapbuild.py (+1/-0)
lib/lp/snappy/tests/test_snapbuildbehaviour.py (+12/-1)
lib/lp/testing/factory.py (+8/-5)
- William Grant (community): Approve (code)
-
Diff: 511 lines (+322/-3)10 files modifiedlib/lp/snappy/browser/snap.py (+26/-2)
lib/lp/snappy/browser/tests/test_snap.py (+16/-0)
lib/lp/snappy/browser/widgets/snapbuildchannels.py (+99/-0)
lib/lp/snappy/browser/widgets/templates/snapbuildchannels.pt (+16/-0)
lib/lp/snappy/browser/widgets/tests/test_snapbuildchannelswidget.py (+132/-0)
lib/lp/snappy/model/snapbuildbehaviour.py (+2/-1)
lib/lp/snappy/templates/snap-edit.pt (+3/-0)
lib/lp/snappy/templates/snap-index.pt (+15/-0)
lib/lp/snappy/templates/snap-new.pt (+3/-0)
lib/lp/snappy/tests/test_snapbuildbehaviour.py (+10/-0)
- William Grant (community): Approve (code)
-
Diff: 241 lines (+105/-15)6 files modifiedlib/lp/snappy/browser/snap.py (+0/-7)
lib/lp/snappy/browser/widgets/snapbuildchannels.py (+21/-0)
lib/lp/snappy/browser/widgets/tests/test_snapbuildchannelswidget.py (+39/-3)
lib/lp/snappy/interfaces/snap.py (+2/-0)
lib/lp/snappy/model/snapbuildbehaviour.py (+11/-4)
lib/lp/snappy/tests/test_snapbuildbehaviour.py (+32/-1)
Changed in launchpad: | |
assignee: | Sergio Schvezov (sergiusens) → Colin Watson (cjwatson) |
Changed in launchpad-buildd: | |
assignee: | Sergio Schvezov (sergiusens) → Colin Watson (cjwatson) |
Changed in launchpad-buildd: | |
status: | Triaged → In Progress |
Changed in launchpad: | |
status: | Triaged → In Progress |
Changed in launchpad-buildd: | |
status: | In Progress → Fix Committed |
Changed in launchpad-buildd: | |
status: | Fix Committed → Fix Released |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
<sergiusens> cjwatson btw, mind if we work on switching snapcraft to use the snap for lp buidlers?
<cjwatson> sergiusens: I don't mind, but how were you planning to go about it?
<cjwatson> it's a bit involved
<sergiusens> cjwatson oh, then step one would be to get an idea of how involved it is :-)
<sergiusens> I had the impression it would be more about testing that s/apt install snapcraft/snap install snapcraft --classic/ was working as expected on staging
<cjwatson> sergiusens: we need to make it be a switch, not just change it in the code (which is harder to roll back, harder to experiment with on particular snaps, etc.); and probably as part of the same chunk of work we need to add channel control
<cjwatson> sergiusens: which means it needs to be propagated down from the LP buildd-manager, and probably needs data model changes
<sergiusens> cjwatson up to LP or even build.snapcraft.io ?
<sergiusens> I'll write up the proposed set of steps on the forum
<cjwatson> sergiusens: not build.snapcraft.io IMO. We can flip the switch eventually but it needs to be controlled
<cjwatson> sergiusens: IMO the steps are: (1) design data model in LP (possibly taking into account where core is installed from too, at least for the future?) (2) add option to snap build type in launchpad-buildd to cause it to install snapcraft as a snap (3) LP database migration to add whatever new columns we need (4) implement new data model and API changes in LP, and adjust the build args sent to builders (5) possible UI changes
<cjwatson> sergiusens: ordering is important because builders, DB migrations, LP code are all deployed independently so we need to ensure the right kind of compatibility