FeedBase derives from LaunchpadFormView for no good reason
Bug #172981 reported by
James Henstridge
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Triaged
|
Low
|
Unassigned |
Bug Description
The FeedBase class in canonical.
Further more, it ends up disabling all the setup that LaunchpadFormView does:
def initialize(self):
"""See `IFeed`."""
# This method must not delegate to the superclass method as it does
# things that are inappropriate (e.g. set up widgets) for a Feed
# class. Therefore this implementation must not be removed and
# invoking the super class version must not happen.
pass
Is there any reason why this class doesn't just use LaunchpadView instead?
visibility: | private → public |
Changed in launchpad: | |
status: | New → Triaged |
importance: | Undecided → Low |
tags: | added: tech-debt |
To post a comment you must log in.